Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Session garbage collection configuration #8053

Conversation

viktorpetryk
Copy link
Contributor

@viktorpetryk viktorpetryk commented Oct 15, 2020

Purpose of this pull request

This pull request (PR) adds a new section about configuring garbage collection in the env.php file.

Affected DevDocs pages

Links to Magento source code

whatsnew
Added a new section about configuring garbage collection in Magento to clean up expired sessions.

@magento-engcom-team
Copy link

@victorpetryk thank you for contributing. Please accept Community Contributors team invitation here to gain extended permissions for this repository.

@m2-community-project m2-community-project bot added this to Ready for Review in Pull Request Progress Oct 15, 2020
@jeff-matthews jeff-matthews self-assigned this Oct 15, 2020
@m2-community-project m2-community-project bot moved this from Ready for Review to Review in Progress in Pull Request Progress Oct 15, 2020
@jeff-matthews jeff-matthews added the Internal Dev Differentiates work between community and Magento staff label Oct 15, 2020
@jeff-matthews jeff-matthews added Major Update Significant original updates to existing content 2.4.2 labels Oct 15, 2020
@jeff-matthews
Copy link
Contributor

@victorpetryk, does this apply to both the 2.4.x and 2.3.x release lines or 2.4.x only?

@jeff-matthews jeff-matthews self-requested a review October 15, 2020 14:37
src/_includes/config/locate-session.md Outdated Show resolved Hide resolved
src/_includes/config/locate-session.md Outdated Show resolved Hide resolved
src/_includes/config/locate-session.md Outdated Show resolved Hide resolved
src/_includes/config/locate-session.md Outdated Show resolved Hide resolved
src/_includes/config/locate-session.md Outdated Show resolved Hide resolved
@m2-community-project m2-community-project bot moved this from Review in Progress to Changes Requested in Pull Request Progress Oct 15, 2020
@viktorpetryk
Copy link
Contributor Author

@victorpetryk, does this apply to both the 2.4.x and 2.3.x release lines or 2.4.x only?

@jeff-matthews This applies to 2.4.x only as changes to configure garbage collection from env.php file will be delivered to 2.4.2

@jeff-matthews
Copy link
Contributor

jeff-matthews commented Oct 15, 2020

Thanks for confirming @victorpetryk.

Since it applies to 2.4.x only, I need you to do the following:

  1. Replace the symlinked src/guides/v2.4/config-guide/sessions.md file with a copy of the src/guides/v2.3/config-guide/sessions.md file.
  2. Replace the include reference ({% include config/locate-session.md %}) from the new 2.4 file with the revised text of your new section (e436d77). We don't use this include file anywhere else in devdocs, so I don't think we need it for 2.4.
  3. Revert all changes to the src/_includes/config/locate-session.md file. This will be used for 2.3 only and should not contain information about garbage collection.

I understand that may be tedious, so if you prefer, I would be happy to create a copy of your branch and do it for you in a new PR. Just let me know what you prefer.

@viktorpetryk
Copy link
Contributor Author

@jeff-matthews Let me ask PO about the necessity to backport a fix about GC to the 2.3.x release line. And if so the devdocs will need to be updated for 2.3.x as well.

@viktorpetryk
Copy link
Contributor Author

@jeff-matthews I've created a backported fix for the 2.3.x release line. So we can continue to proceed with this PR.

@jeff-matthews
Copy link
Contributor

Sounds good @victorpetryk. Thanks!

@jeff-matthews
Copy link
Contributor

running tests

Pull Request Progress automation moved this from Changes Requested to Reviewer Approved Oct 20, 2020
@ghost
Copy link

ghost commented Oct 20, 2020

Hi @victorpetryk, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@m2-community-project m2-community-project bot moved this from Reviewer Approved to Done in Pull Request Progress Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.4.2 Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants